[
https://issues.apache.org/jira/browse/PDFBOX-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606354#comment-17606354
]
Michael Klink commented on PDFBOX-5513:
---------------------------------------
{quote}What's your proposal? ...{quote}
Something along those lines, I'm merely not sure why one should default for the
empty name; the empty name is a name after all.
An alternative to the exception could be a new {{PageLayout}} value
UNSPECIFIED. People could then decide whether to handle this situation like the
default value, as an error, or whether to retrieve the actual value and look at
it more closely.
The OP mentions that {{getPageMode}} already caught a
`IllegalArgumentException` and returned the default instead. It think that
handling these situations alike is even mode important than the approach used.
> getPageLayout throws IllegalArgumentException for empty mode
> ------------------------------------------------------------
>
> Key: PDFBOX-5513
> URL: https://issues.apache.org/jira/browse/PDFBOX-5513
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
> Affects Versions: 2.0.25, 2.0.26, 3.0.0 PDFBox
> Reporter: Karol Bryd
> Assignee: Tilman Hausherr
> Priority: Major
> Fix For: 2.0.27, 3.0.0 PDFBox
>
> Attachments: page_layout_issue.patch
>
>
> getPageLayout() method in PDDocumentCatalog can throw an exception
> IllegalArgumentException when the PageLayout mode is not one of defined in
> the PageLayout class. In my case the mode is simply an empty string.The PDF
> documents which contain such unexpected Page Layout value are all rendered by
> quite old Adobe PDF library 7.0 from 2014 (I can't share the document, it is
> confidential....).
> My suggestion is to modify the method so that, similarly to getPageMode()
> method, the eventual exception is caught and the method returns the default
> PageLayout.{color:#9876aa}SINGLE_PAGE {color}mode.{color:#9876aa}
> {color}
>
> This problem affects the current version in trunk, as well as at least 2.0.25
> and 2.0.26.
>
> I have created very simple patch which fixes the problem, please consider
> applying it to the trunk and 2.0.x branch.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
