Dear Thorsten Hake, please open an improvement issue in https://issues.apache.org/jira/browse/PDFBOX and attach your patch there.
This way committers will see your patch and process it as necessary. Kind regards, Timo Am 19.11.2012 12:24, schrieb Thorsten Hake:
Hello, we'm using PDFBox in our current project to print a pdf file directly to an attached network printer. Printing PDF documents having only portrait pages within worked like a charm. Thank you very much for this! However we experienced problems with PDFs having LANDSCAPE pages defined, as the orientation is currently always defined by the printer service and not by the PDDocument. This may be desireable in some situations but undesirable in others (like others). Printing PDFs with PORTRAIT and LANDSCAPE pages in one document may lead to strange print results as the landscape pages are truncated to a PORTRAIT width. To allow the user of the PDFBox API to choose which orientation determination algorithm he wants to use, I've changed the current 1.7.1 version so that an "OrientationResolver" can be handled to the print methods. This OrientationResolver will be used by the PDPageable to determine the format of the page to be printed. Please have a look at the attached patch. It was inspired by the comment in Bug https://issues.apache.org/jira/browse/PDFBOX-985. I currently don't know what negative implications my patch has as I haven't fully grasped other usages of the print method, but it definitly helped me printing LANDSCAPE pages correctly. Also, I would like to know what I'll have to do to contribute this patch to the trunk. Whom do I have to contact? Thank you very much in advance. Greetings, Thorsten Hake
-- Timo Boehme OntoChem GmbH H.-Damerow-Str. 4 06120 Halle/Saale T: +49 345 4780474 F: +49 345 4780471 timo.boe...@ontochem.com _____________________________________________________________________ OntoChem GmbH Geschäftsführer: Dr. Lutz Weber Sitz: Halle / Saale Registergericht: Stendal Registernummer: HRB 215461 _____________________________________________________________________
