+1 for the merge although there are some problems listed below. - In DefaultVolumeChoosingPolicy.chooseVolume(..), getCurrentUsage() is called multiple times so it can return different values. The biggest problem is the sorted(..) call. The code calls getCurrentUsage() in the comparator. The behavior is ill-defined for sorting changing values.
- DatanodeDiskBalancerInfoProto should use DatanodeIDProto instead of DatanodeDetailsProto - Remove DatanodeDiskBalancerInfoType since it is never used. - Do not throw RuntimeException in TestContainerChoosingPolicy. How about using Assertions.fail(e.getMessage())? Thanks for working on this! Tsz-Wo On Fri, Dec 12, 2025 at 12:49 AM Janus Chow <[email protected]> wrote: > +1 for the merge. > > Warm Regards. > > -- > Yiyang Zhou > > > Sadanand Shenoy <[email protected]> 于2025年12月12日周五 13:55写道： > > > +1 for the merge. > > > > - Sadanand > > > > On Wed, Dec 10, 2025 at 3:53 PM Sammi Chen <[email protected]> wrote: > > > > > Hi Ozone developers, > > > > > > This is for merging the HDDS-5713 Disk Balancer feature branch into > > master. > > > > > > HDDS-5713 adds the support of the disk volume utilization balancer > > function > > > by selecting and moving containers from high utilized data volume to > > lower > > > utilized data volume, to achieve an all disk volumes' utilization even > > > state. > > > > > > Feature Jira Link: > > > https://issues.apache.org/jira/browse/HDDS-5713 > > > > > > Checklist for feature branch merge: > > > > > > > > > https://cwiki.apache.org/confluence/display/OZONE/Disk+Balancer+For+Datanode+-+HDDS-5713 > > > < > > > > > > https://cwiki.apache.org/confluence/display/OZONE/Disk+Balancer+For+Datanode+-+HDDS-5713 > > > > > > > > > > Please help to take a look and cast the vote if you have time. > > > > > > The vote will be open for at least a week. > > > BTW, previous thread link > > > <https://lists.apache.org/thread/szyx6jxx1f66fzv9bz0t8vq8cdxmt173>. > > > > > > Thanks, > > > Sammi Chen > > > > > >
