+1 for merging the hsync branch. - Nilotpal Nandi
On Tue, Aug 6, 2024 at 8:22 AM Sammi Chen <sammic...@apache.org> wrote: > +1 for merging the hsync branch. > > Note: I have contributed to branch HDDS-7593. > > On Sat, 3 Aug 2024 at 12:22, Ashish kumar <ashis...@apache.org> wrote: > > > Hi Attila, > > > > Compatibility fixes are addressed in the feature branch. > > > > Thanks Wei-Chiu for the fix. > > > > -Ashish > > > > On Thu, Aug 1, 2024 at 4:39 AM Wei-Chiu Chuang <weic...@apache.org> > wrote: > > > > > Thanks Attila for the feedback, > > > > > > It looks to me these protocol versions and layout versions concerns can > > be > > > addressed quickly. I took a stab at it and posted them in three > separate > > > PRs. > > > > > > https://github.com/apache/ozone/pull/7013 HDDS-11258. [hsync] Add new > OM > > > layout version. > > > https://github.com/apache/ozone/pull/7012 HDDS-11259. [hsync] > DataNode > > > should verify HBASE_SUPPORT layout version for every PutBlock. > > > https://github.com/apache/ozone/pull/7015 HDDS-11260. [hsync] Add > Ozone > > > Manager protocol version > > > > > > > > > On Tue, Jul 30, 2024 at 11:02 PM Attila Doroszlai < > adorosz...@apache.org > > > > > > wrote: > > > > > > > > > Both issues can be addressed with new layout versions. I will > open > > > JIRA > > > > > > tickets to include these fixes in the next release, version > 1.5.0. > > > > > > > > > > Thanks Wei-Chiu, I'm ok with handling these in follow up tasks. > > Please > > > > > share the Jira links when you have them. This was my main concern, > so > > > the > > > > > merge is +1 from me now. > > > > > > > > Thank you for spotting the potential compatibility problems due to > > > > lack of a new layout version. > > > > > > > > Can it be addressed before the feature branch merge? The reason for > > > > using feature branches in the first place is to keep master in a > state > > > > that's usable/releasable as is. If we address such issues as > > > > follow-up, the feature could have been developed on master. > > > > > > > > -Attila > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > > > > For additional commands, e-mail: dev-h...@ozone.apache.org > > > > > > > > > > > > > >
