Hi Ashish, thanks for the updates. Regarding this:
> In the old design, lease recovery was dependent only on the client and OM, > but now it involves datanode as well. I'm not quite following because the master branch already has an OM layout feature called "hsync" that is finalized for any deployments of master since May of last year when initial hsync development was happening on master. On the branch I don't see any new versions on the OM or datanode related to lease recovery. FYI your gmail address was going to my spam folder, this may have happened for others as well. Since you are a committer can you use your apache email to send messages? On Mon, Jul 29, 2024 at 4:05 AM Ashish kumar <ashis.kr.2...@gmail.com> wrote: > Thanks Ethan for looking into this. > > >>It looks like this line in the merge checklist was not updated. > Updated the checklist. > > >> Can you go > into more details about the OM compatibility for lease recovery or other > operations? > Lease recovery is completely redesigned and so both client and server needs > to be upgraded to make it work correctly. > In the old design, lease recovery was dependent only on the client and OM, > but now it involves datanode as well. > Apart from this compatibility is related to "Incremental chunk list" which > is already taken care of. > > >> DataNode layout version "HBASE_SUPPORT" > Yes this is only related to incremental chunk list. We will update with a > more meaningful name as HBASE_INCREMENTAL_CHUNK_SUPPORT. > Also will update the merge checklist in more detail about this. > > Thanks, > Ashish > > On Fri, Jul 26, 2024 at 12:50 AM Ethan Rose <er...@apache.org> wrote: > > > Thanks for all the work on this. Looks good overall, just a few > > questions on compatibility: > > > > It looks like this line in the merge checklist was not updated. Can you > go > > into more details about the OM compatibility for lease recovery or other > > operations? > > > > > A new OM version number was introduced to prevent new client sending > > > atomic key overwrite request to old OM which does not support this > > feature. > > > > > > Additionally, new DataNode layout version "HBASE_SUPPORT" was added. > > > > Can you add some details about what changes on the disk layout after this > > feature is finalized? Is this related to the incremental chunk list or > > something more? Perhaps a more descriptive layout feature name would help > > here as well. > > > > Ethan > > > > On Wed, Jul 24, 2024 at 11:43 PM Wei-Chiu Chuang <weic...@apache.org> > > wrote: > > > > > I am +1 (binding) > > > On Tue, Jul 23, 2024 at 4:05 AM Ashish kumar <ashis.kr.2...@gmail.com> > > > wrote: > > > > > > > Hi Ozone developers, > > > > > > > > I would like to propose merging HDDS-7593 (HSync and lease recovery) > > > > feature branch into master. > > > > > > > > This feature is to support HSync and lease recovery, > > > > which enables HBase to run on Ozone. > > > > More details about the feature are present in design documents > attached > > > > in the below mentioned Ozone confluence page link. > > > > > > > > > > > > Checklist for feature branch merge: > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/OZONE/Supporting+HSync+and+lease+recovery+-+HDDS-7593 > > > > > > > > Feature Jira Link: > > > > https://issues.apache.org/jira/browse/HDDS-7593 > > > > > > > > This vote will be open for at least a week. > > > > > > > > Thanks, > > > > Ashish Kumar > > > > > > > > > >
