Hi Doung, thank you for this work, I have reviewed a good part of the commits, and ran through the diff of the branch from the master, we worked on the design together, with that I think this one is good to go in.
+1 Pifta Uma Maheswara Rao Gangumalla <umaganguma...@gmail.com> ezt írta (időpont: 2023. jún. 5., H, 0:27): > +1 > > Regards, > Uma > > On Wed, May 31, 2023 at 5:40 PM Duong Nguyen <du...@apache.org> wrote: > > > Hi Ozone Devs, > > > > Following the discussion thread regarding the same topic, I'm starting > this > > vote thread for merging the feature branch HDDS-7733-Symmetric-Tokens to > > master. > > The discussion thread > > <https://lists.apache.org/thread/8hlxsj3f3n1tzgcsv6g94mb5jkkzlg8z> can > be > > found here. > > > > This feature branch contains the implementation to replace the costly > token > > signature generation using asymmetric (RSA) keys with symmetric key > > algorithms, like HMAC with SHA256. Symmetric key algorithms bring a > > much better performance and are the natural fit for Ozone token use case. > > Yet, they require building a mechanism to generate, store, distribute, > and > > renew symmetric secret keys. That requirement is not trivial and has to > be > > split into smaller tasks that cannot be shipped individually. That is > > the reason why the implementation of HDDS-7733 > > <https://issues.apache.org/jira/browse/HDDS-7733> happens in a separate > > feature branch. > > > > More information can be found on the wiki page: > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255070328 > > > > Thanks, > > Duong > > > -- Pifta