+1 on the need to address upgrade concerns in the wiki. Snapshots should be usable only after finalization.
Whether a layout feature is needed or not, IMO if no current on-disk layout has changed we should not need it. Ethan? Best, Sid On Wed, Jan 11, 2023 at 9:53 AM Ethan Rose <er...@cloudera.com.invalid> wrote: > Hey Prashant, thanks for all the work on this feature. I think the > confluence page needs a few updates for completeness. > > > > *2. documentation* > > > > Documentaion can be found under the Attachments section in the umbrella > > jira: HDDS-6517 <https://issues.apache.org/jira/browse/HDDS-6517> - > Snapshot > > support for Ozone OPEN > > > > This bullet refers to user facing documentation to be added to > https://ozone.apache.org/docs/current/. It is not the same as "3. design, > attached the docs". If the docs are not done yet, I think a link to an open > jira would be sufficient. > > > *9. possible incompatible changes/used feature flag: * > > > > There should not be any incompatible changes introduced with this > feature. > > > > An enable/disable switch is not required. Snapshot feature has its > > independent se of CLIs that need not be exercised. > > > > I'm not sure what the merge template intends for the difference between 9 > and 4 is. Anyways, it looks like snapshots will need a layout feature to > make sure it is not used before Ozone has been finalized. Again, I think > linking to an open jira would be sufficient here. If it can be done without > a layout feature somehow, an explanation in this part of the page would be > good. > > With these minor updates I think the merge would be good to go. > > Ethan > > > On Tue, Jan 10, 2023 at 2:56 PM Prashant Pogde <ppo...@cloudera.com.invalid > > > wrote: > > > Dear Ozone Devs, > > > > We would like to start this discussion thread for the proposal to merge > > https://issues.apache.org/jira/browse/HDDS-6517 Ozone Snapshots. > > > > Ozone Snapshot feature allows us to take a point in time frozen image of > > the Ozone dataset. Initially this feature would allow snapshots to be > taken > > at bucket granularity. Subsequently the feature can support Snapshots > > at Volume level as well as the whole Ozone Namespace level. > > > > Note that HDDS-6517 is a new feature such that it is mainly adding new > > code. Therefore, the risk is very low to the existing functionalities > and > > features in Ozone. > > > > When the Snapshot feature is not used, it should cause no impact to the > > master. > > For more information, please check out Ozone Snapshot feature Jira > > (HDDS-6517) and feature wiki page here: > > > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots > > > > If there are no objections for the merge, we could start the official > vote. > > > > Thanks, > > Ozone Snapshot Team >
