Hi Ethan, Thanks for working on making the FSO the default type of bucket. Besides test failures, I think so far there are still several known issues for FSO, for example the quota on FSO is breaking. We'd better fix all these know issues before we set FSO as the default bucket type. For the issue you mentioned, mkdir failure on LEGACY bucket, it looks like a critical issue. We probably should fix that in 1.3. It's been almost a year since last Ozone release(Dec last year). I think we have too less releases in community. It's not a very healthy sign. So my general suggestion is, having the mkdir failure fix in 1.3 and the rest can be in next release.
Bests, Sammi On Thu, 17 Nov 2022 at 09:42, Ethan Rose <er...@cloudera.com.invalid> wrote: > Hi all, sorry to crash this thread again, but I found another issue we may > want to look into for 1.3.0. It turns out the default bucket layout type > is set to LEGACY, which means that most new ozone clusters will continue to > create legacy buckets if they are not aware bucket layouts have been added. > Additionally, if mkdir via ofs is used on a pre-finalized cluster and it > requires creating a bucket, this will fail because the default value > of ozone.client.fs.default.bucket.layout is set to FSO, but the > pre-finalized ozone cluster will not allow FSO buckets. The PR > <https://github.com/apache/ozone/pull/3966> to fix both of these things is > currently underway, but since it is basically changing the default bucket > type for all the tests, there are numerous failures I am still working > through. > > Please let me know your thoughts on the severity of this issue and whether > it should be a blocker or not. > > Ethan > > On Wed, Nov 16, 2022 at 5:04 AM mingchao zhao <captain...@apache.org> > wrote: > > > Thanks Ethan and Sammi for the tip. > > I will cherry pick this patch to ozone-1.3 and start a new rc. > > > > On Wed, Nov 16, 2022 at 10:29 AM Sammi Chen <sammic...@apache.org> > wrote: > > > > > Agree. > > > > > > https://github.com/apache/ozone/pull/3961 fixed a severe problem. > > > > > > We'd better have it in 1.3.0 release. > > > > > > Bests, > > > Sammi > > > > > > On Wed, 16 Nov 2022 at 02:42, Ethan Rose <er...@cloudera.com.invalid> > > > wrote: > > > > > > > We recently had a PR <https://github.com/apache/ozone/pull/3961> > > merged > > > > that fixes SCM HA finalization using the incorrect RocksDB table to > > write > > > > information. Since this is a new feature in 1.3.0 it seems like we > > should > > > > cherry pick this to the release branch and make an RC1. MingChao and > > > > others, what do you think? > > > > > > > > Ethan > > > > > > > > On Mon, Nov 14, 2022 at 5:55 AM mingchao zhao <captain...@apache.org > > > > > > wrote: > > > > > > > > > Thanks Kaijie for your confirmation. > > > > > Previously, we had upgraded ratis mainly to solve the memory leak > of > > > > grpc. > > > > > Ratis 2.4.1 does have some improvements, > > > > > but it doesn't seem to have necessary bugs fixed for ozone.(Please > > let > > > me > > > > > know if there is anything patch we need) > > > > > > > > > > So we can just upgrade it in master branch. This way we will not > > block > > > > the > > > > > release of ozone 1.3.0 with ratis. > > > > > > > > > > On Mon, Nov 14, 2022 at 8:45 PM Kaijie Chen <c...@apache.org> > wrote: > > > > > > > > > > > +1, Thanks mingchao for the work. > > > > > > > > > > > > Verified: > > > > > > 1. Checksum and signature matches. > > > > > > 2. Successfully built from source. > > > > > > 3. Commit hash of the binary matches. > > > > > > 4. Checked LICENSE and NOTICE. > > > > > > 5. Successfully deployed on a cluster. > > > > > > 6. Run basic tests with freon. > > > > > > > > > > > > PS: Should we wait for Ratis 2.4.1 release? > > > > > > > > > > > > Kaijie > > > > > > > > > > > > ---- On Mon, 14 Nov 2022 19:54:43 +0800 mingchao zhao wrote > --- > > > > > > > Hello all, > > > > > > > > > > > > > > As discussed earlier, I am calling for a vote on Apache Ozone > > > 1.3.0 > > > > > RC0. > > > > > > > > > > > > > > 735 Jiras were resolved as part of this release: > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20HDDS%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%201.3.0 > > > > > > > > > > > > > > The RC0 tag can be found on Github at: > > > > > > > https://github.com/apache/ozone/releases/tag/ozone-1.3.0-RC0 > > > > > > > > > > > > > > The source and binary tarballs can be found at: > > > > > > > https://dist.apache.org/repos/dist/dev/ozone/1.3.0-rc0/ > > > > > > > > > > > > > > Maven artifacts are staged at: > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheozone-1010/ > > > > > > > > > > > > > > The public key used to sign the artifacts can be found at: > > > > > > > https://dist.apache.org/repos/dist/dev/ozone/KEYS > > > > > > > > > > > > > > The fingerprint of the key used to sign the artifacts is: > > > > > > > 579BA5230BBD258030A909601E3600CAA819185F > > > > > > > > > > > > > > The vote will run for 7 days, ending on Nov 21th 2022 at 19:52 > > pm > > > > > UTC+8. > > > > > > > > > > > > > > -- > > > > > > > Thanks > > > > > > > MingChao > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > > > > > > For additional commands, e-mail: dev-h...@ozone.apache.org > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Thanks > > > > > MingChao > > > > > > > > > > > > > > > > > > -- > > Thanks > > MingChao > > >