Thanks Mukul. Note that all open PRs based on master branch after Tue Mar 2 11:11:58 2021 PST (commit time of HDDS-4864) may need to be rebased due to the divergence.
-Siyao On Mar 24, 2021 at 10:27:24 PM, Mukul Kumar Singh <mksingh.apa...@gmail.com> wrote: > Thanks everyone. > > I have pushed the changes to the master branch. > > Please resume any merges to Apache master. > > Thanks, > > Mukul > > On 25/03/21 10:30 am, Mukul Kumar Singh wrote: > > Thanks Arpit and Sammi for the responses. > > > Note: Please block any merges to Apache master while this commit is > > being removed. > > > I will send out another email once the process is done. > > > > Thanks, > > Mukul > > > On 25/03/21 9:19 am, Sammi Chen wrote: > > > +1 > > > > > > Thanks Mukul for raising the issue. > > > > > > On Thu, Mar 25, 2021 at 10:33 AM Mukul Kumar Singh > > > <mksingh.apa...@gmail.com> > > > wrote: > > > > > >> Hi, > > >> > > >> > > >> Recently, through one of the jiras(HDDS-4864), aws_secret_access_key > > >> was > > >> committed into Ozone's source code. Secrets, gpg passphrases, > > >> passwords, > > >> ssh private files should not be committed into Ozone source code as > > >> they > > >> leak credentials into the source code. > > >> > > >> This issue will be solved via the following steps > > >> > > >> a) The above commit will be removed from the Ozone commit history. We > > >> will force push to the Ozone master branch with this commit removed. > > >> > > >> b) A new commit hook/ CI check will be added to prevent this from > > >> hapennening again. > > >> > > >> Please hold off on merging any new changes into Ozone until the commit > > >> is removed from Apache commit history. > > >> > > >> Thanks, > > >> > > >> Mukul > > >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > > >> For additional commands, e-mail: dev-h...@ozone.apache.org > > >> > > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > For additional commands, e-mail: dev-h...@ozone.apache.org > >
