+1 > On 26-Jan-2021, at 2:31 PM, István Fajth <fapi...@gmail.com> wrote: > > I have been bought, +1 on the idea, especially as this is something that is > a long standing thing in the jls, which is not at all hard to conform, and > most if not all of the devs are used to the correct order. > > Pifta > > Rui Wang <amaliu...@apache.org> ezt írta (időpont: 2021. jan. 26., K, 6:42): > >> Forcing modifier order seems not to update existing codebase much, and it >> does not cause too much burden for new PRs thus it makes sense to me. >> >> >> -Rui >> >>> On Mon, Jan 25, 2021 at 5:19 PM Lamber Ken <lamber...@apache.org> wrote: >>> >>> Hi Community, >>> >>> According to "Java Language Specification"[1], found some problems that X >>> modifier out of >>> order with the JLS suggestions in the codebase. So, I think we can add >>> ModifierOrder to checkstyle rules to enforce modifier order[2]. >>> >>> I don't know if other people have opinions on it. >>> >>> [1]: https://docs.oracle.com/javase/specs/jls/se11/html/jls-8.html >>> >>> [2]: https://github.com/apache/ozone/pull/1839 >>> >>> >>> >>> Thanks, >>> Lamber-Ken >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org >>> For additional commands, e-mail: dev-h...@ozone.apache.org >>> >>> >> > > > -- > Pifta
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
