Did the general review of the PR. Also +1 to merge.
Thanks, Yiqun From: Vivek Ratnavel <vivekratna...@apache.org> Date: Friday, November 13, 2020 at 2:36 AM To: dev@ozone.apache.org <dev@ozone.apache.org> Subject: Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880) +1 to merge Thanks for working on this Stephen! On Thu, Nov 12, 2020 at 7:46 AM Stephen O'Donnell <sodonn...@cloudera.com.invalid> wrote: > Following on from the discussion thread, I would like to call a vote on > whether we should merge HDDS-1880 into master. This feature will enable > decommission and maintenance mode for datanodes. The feature is working, > but more work is needed to improve the usability etc. I feel the feature is > stable and self contained enough to continue that work on the master branch > now > > The overall design is under HDDS-1880 and there is a summary of the > internals also attached to that Jira. > > A PR for the merge is here: > > https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fozone%2Fpull%2F1580&data=04%7C01%7Cyiqlin%40ebay.com%7C664bb86ab58e425e1ed408d88739e171%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637408029952904737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KxdTPR8jn4RbtwcHxEpbLyDsmurIbM%2FLBW1aQGAVXzY%3D&reserved=0 > > I will try to keep the PR up-to-date if any conflicts arise. > > From the discussion thread, I can carry over 1 +1 from Marton Elek to get > us started. > > As it may take some time to review the large PR I will let the vote run for > 14 days, closing at midnight GMT on 26th November. > > Please ask any questions here, on the PR or on ASF Slack. > > Thanks, > > Stephen. >
