Rodrics latest updates to the nodeJs runtime uncovered that some of our NodeJs 
test actions are using variables in the global scope (by omitting the let or 
var keywords). The related tests are now failing in the Travis build.

I opened https://github.com/apache/incubator-openwhisk/pull/4514 to fix the 
syntax of those actions.
While this PR would fix the build problem, there would be the danger of 
breaking existing customer actions with the runtime changes.

Therefore Rodric additionally opened a PR in the NodeJs runtime to allow these 
syntax quirks again. 
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/136

I do suggest to fix the problem by accepting his runtime PR and only optionally 
merge my core PR with the syntax changes
after we see the problem go away.

Regards,
Martin

Reply via email to