On Sat, Oct 29, 2016 at 1:45 PM, Stephen Finucane <step...@that.guru> wrote:
> On 28 Oct 15:45, Ciara Loftus wrote: > > 'dpdk' ports no longer have naming restrictions. Now, instead > > of specifying the dpdk port ID as part of the name, the PCI > > address of the device must be specified via the 'dpdk-devargs' > > option. eg. > > > > ovs-vsctl add-port br0 my-port > > ovs-vsctl set Interface my-port type=dpdk > > ovs-vsctl set Interface my-port options:dpdk-devargs=0000:06:00.3 > > > > The user must no longer hotplug DPDK ports by issuing specific > > ovs-appctl commands. The hotplug is now automatically invoked when a > > valid PCI address is set in the dpdk-devargs. > > > > Signed-off-by: Ciara Loftus <ciara.lof...@intel.com> > > --- > > INSTALL.DPDK-ADVANCED.md | 9 +-- > > INSTALL.DPDK.rst | 14 +++-- > > NEWS | 2 + > > lib/netdev-dpdk.c | 153 ++++++++++++++++++------------ > ----------------- > > vswitchd/vswitch.xml | 8 +++ > > 5 files changed, 77 insertions(+), 109 deletions(-) > > > > diff --git a/INSTALL.DPDK-ADVANCED.md b/INSTALL.DPDK-ADVANCED.md > > index 7d90219..577e412 100644 > > --- a/INSTALL.DPDK-ADVANCED.md > > +++ b/INSTALL.DPDK-ADVANCED.md > > @@ -892,14 +892,7 @@ dpdk_nic_bind.py script: > > > > Then it can be attached to OVS: > > > > -`ovs-appctl netdev-dpdk/port-attach 0000:01:00.0` > > - > > -At this point, the user can create a ovs port using the add-port > command. > > - > > -It is also possible to detach a port from ovs, the user has to remove > the > > -port using the del-port command, then it can be detached using: > > - > > -`ovs-appctl netdev-dpdk/port-detach dpdk0` > > +`ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk > options:dpdk-devargs=0000:01:00.0` > > > > This feature is not supported with VFIO and could not work with some > NICs, > > please refer to the [DPDK Port Hotplug Framework] in order to get more > > diff --git a/INSTALL.DPDK.rst b/INSTALL.DPDK.rst > > index b917828..2f41f40 100644 > > --- a/INSTALL.DPDK.rst > > +++ b/INSTALL.DPDK.rst > > @@ -249,12 +249,14 @@ Bridges should be created with a > ``datapath_type=netdev``::: > > > > $ ovs-vsctl add-br br0 -- set bridge br0 datapath_type=netdev > > > > -Now you can add DPDK devices. OVS expects DPDK device names to start > with > > -``dpdk`` and end with a portid. ovs-vswitchd should print the number of > dpdk > > -devices found in the log file::: > > - > > - $ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk > > - $ ovs-vsctl add-port br0 dpdk1 -- set Interface dpdk1 type=dpdk > > +Now you can add dpdk devices. The PCI address of the device needs to be > > +set using the 'dpdk-devargs' option. vswitchd should print (in the log > file) > > +the PCI addresses of dpdk devices found during initialisation. > > + > > +``` > > +ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk > options:dpdk-devargs=0000:06:00.0 > > +ovs-vsctl add-port br0 dpdk1 -- set Interface dpdk1 type=dpdk > options:dpdk-devargs=0000:06:00.1 > > +``` > > I won't review the rest of this (I've no idea what I'm looking at), but > this is not a reStructuredText document so some changes are needed. For > to be clear, this is *now* a rst document ... > this to display correctly, you need to precede commands with a '$' > symbol, use the rST-style code block formatting and wrap at < 80 > characters, where possible. For example: > > :: > > $ ovs-vsctl add-port br0 dpdk0 \ > -- set Interface dpdk0 type=dpdk options:dpdk-devargs=0000:06: > 00.0 > > See the DocumentationStyle doc for more info. > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
