Hi Flavio, I was thinking that instead of having a separate appctl we could integrate the attach into netdev_dpdk_construct() while changing the naming convention, as discussed here:
http://openvswitch.org/pipermail/dev/2016-August/078113.html What do you think? Thanks, Daniele 2016-10-26 11:22 GMT-07:00 Flavio Leitner <f...@sysclose.org>: > > Hi Mauricio, > > Could you please rebase this patch? It doesn't apply anymore. > I will review ASAP. > Thanks! > Flavio > > On Fri, Jul 15, 2016 at 04:15:31PM +0200, Mauricio Vasquez B wrote: > > In order to use dpdk ports in ovs they have to be bound to a DPDK > > compatible driver before ovs is started. > > > > This patch adds the possibility to hotplug (or hot-unplug) a device > > after ovs has been started. The implementation adds two appctl commands: > > netdev-dpdk/port-attach and netdev-dpdk/port-detach > > > > After the user attaches a new device, it has to be added to a bridge > > using the add-port command, similarly, before detaching a device, > > it has to be removed using the del-port command. > > > > Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@ > studenti.polito.it> > > --- > > v7: > > - rebase to master > > v6: > > - add explicit comment about supporting VFIO > > - rebase to master > > v5: > > - use two appctl commands instead of a single one > > - rebase to master > > v4: > > - fix typo in commit message > > - remove unnecessary whitespace change in INSTALL.DPDK.md > > v3: > > - create dpdk_port_attach and dpdk_port_detach functions > > - modify mutex locking order > > v2: > > - use rte_eth_dev_is_valid_port() to check if a port is valid > > INSTALL.DPDK-ADVANCED.md | 25 ++++++++++++ > > NEWS | 1 + > > lib/netdev-dpdk.c | 101 ++++++++++++++++++++++++++++++ > +++++++++++++---- > > 3 files changed, 120 insertions(+), 7 deletions(-) > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
