With the nit below,
Acked-by: Jarno Rajahalme <ja...@ovn.org>
> On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy
> <bhanuprakash.bodire...@intel.com> wrote:
>
> This patch checks if trash is non-zero and only then resets the flowmap
> bit and increment the pointer by set bits as found in trash.
>
> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com>
> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com>
> ---
> lib/flow.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/flow.h b/lib/flow.h
> index 4eb19ae..8cfd243 100644
> --- a/lib/flow.h
> +++ b/lib/flow.h
> @@ -609,11 +609,13 @@ mf_get_next_in_map(struct mf_for_each_in_map_aux *aux,
> * corresponding data chunks should be skipped accordingly. */
> map_t trash = *fmap & (rm1bit - 1);
>
> - *fmap -= trash;
> + if (trash) {
> + *fmap -= trash;
> /* count_1bits() is fast for systems where speed matters (e.g.,
> * DPDK), so we don't try avoid using it.
> * Advance 'aux->values' to point to the value for 'rm1bit'. */
You should update the comment, as we now avoid calling count_1bits().
> - aux->values += count_1bits(trash);
> + aux->values += count_1bits(trash);
> + }
>
> *value = *aux->values;
> } else {
> --
> 2.4.11
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
