On Wed, Aug 31, 2016 at 03:22:44PM +0000, Ryan Moats wrote: > As discussed in [1], what the incremental processing code > actually accomplished was that the ovn-controller would > be "quiet" and not burn CPU when things weren't changing. > This patch set recreates this state by calculating whether > changes have occured that would require a full calculation > to be performed. It does this by persisting a copy of > the localvif_to_ofport and tunnel information in the > controller module, rather than in the physical.c module > as was the case with previous commits. > > [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com>
Hi Ryan. I like the idea behind this patch. However, it no longer applies to master, so it needs a rebase. It also seems like this TODO should be addressed: + /* TODO (regXboi): this next line is needed for the 3 HVs, 3 LS, + * 3 lports/LS, 1 LR test case, but has the potential side effect + * of defeating quiet mode once a logical router leads to creating + * patch ports. Need to understand the failure mode better and + * what is needed to remove this. */ + force_full_process(); Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
