Thanks for your tips, I fixed the memory leak(via free(ips)). The patch follows the style of the original code. So the 'const' is not used with 'may_exist', 'add_duplicate' and 'must_exist'. You can find that in files, such as 'utilities/ovs-vsctl.c', 'ovn/utilities/ovn-sbctl.c' and 'ovn/utilities/ovn-nbctl.c'. If necessary, I will submit an individual patch.
> On Sep 30, 2016, at 5:30 AM, Flavio Fernandes <fla...@flaviof.com> wrote: > > comments/suggestions inline. > > Also, I'd think it would be good to run with valgrind [1] to see if there is > any error codepath > that may be causing leaks. > > -- flaviof _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
