Hi All,
Since this is my first post to the list, I'd like to take the opportunity
to thank the community and especially the core committers
for all their visible efforts as well as all the effort I know goes on
behind the scenes to keep such an amazing project barrelling along,
even around corners! I look forward to meeting many of you
at OVSCON 2016 and thanking you in person.
This is my first patch and its a minor documentation fix for a small gap
in the doc and code comments for l2gateway logical switch ports relative
to localnet ports. Since my patch is copy/paste from Russell's patches,
I added him as co-author,hopefully that aligns with project contribution
guidelines.
Best regards,
Gabe
8<--------------------------------------------->8
update description of l2gateway logical switch ports to include optional
vlan tag. Also restore comment in ovn/controller/physical.c from original commit
by Russell Bryant (184bc3c ovn: Add software l2 gateway) on 7/1/2016.
Signed-off-by: Gabe Beged-Dov <g...@begeddov.com>
Co-authored-by: Russell Bryant <russ...@ovn.org>
---
ovn/controller/physical.c | 4 ++--
ovn/ovn-nb.xml | 7 ++++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c
index df6990a..96411bd 100644
--- a/ovn/controller/physical.c
+++ b/ovn/controller/physical.c
@@ -202,8 +202,8 @@ consider_port_binding(enum mf_field_id mff_ovn_geneve,
* For a container nested inside a VM and accessible via a VLAN,
* 'tag' is the VLAN ID; otherwise 'tag' is 0.
*
- * For a localnet patch port, if a VLAN ID was configured, 'tag'
- * is set to that VLAN ID; otherwise 'tag' is 0.
+ * For a localnet or l2gateway patch port, if a VLAN ID was
+ * configured, 'tag' is set to that VLAN ID; otherwise 'tag' is 0.
*
* - If the port is on a remote chassis, the OpenFlow port for a
* tunnel to the VIF's remote chassis. 'tun' identifies that
diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml
index c45a444..cd7943c 100644
--- a/ovn/ovn-nb.xml
+++ b/ovn/ovn-nb.xml
@@ -343,10 +343,11 @@
</p>
<p>
- When <ref column="type"/> is set to <code>localnet</code>, this can
+ When <ref column="type"/> is set to <code>localnet</code> or
+ <code>l2gateway</code>, this can
be set to indicate that the port represents a connection to a
- specific VLAN on a locally accessible network. The VLAN ID is used to
- match incoming traffic and is also added to outgoing traffic.
+ specific VLAN on a locally accessible network. The VLAN ID is used
+ to match incoming traffic and is also added to outgoing traffic.
</p>
</column>
--
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
