On Thu, Sep 29, 2016 at 03:13:47PM -0700, Darrell Ball wrote: > On Thu, Sep 29, 2016 at 11:31 AM, Ben Pfaff <b...@ovn.org> wrote: > > > When a VM sends an ARP or an ND NS for its own IP address, it is trying to > > check for a duplicate address in the network. OVN needs to suppress the > > reply in such a case, otherwise the VM thinks that its address is a > > duplicate. > > > > Reported-by: Valentine Sinitsyn <valentine.sinit...@gmail.com> > > Reported-at: http://openvswitch.org/pipermail/dev/2016-September/ > > 080037.html > > Signed-off-by: Ben Pfaff <b...@ovn.org>
... > > diff --git a/tests/ovn.at b/tests/ovn.at > > index 677ab46..68885b9 100644 > > --- a/tests/ovn.at > > +++ b/tests/ovn.at > > @@ -1159,13 +1159,18 @@ for is in 1 2 3; do > > sip=`ip_to_hex 192 168 0 $i$j` > > tip=`ip_to_hex 192 168 0 $id$jd` > > tip_unknown=`ip_to_hex 11 11 11 11` > > - test_arp $s f000000000$s $sip $tip f000000000$d > > #9 > > + if test $d != $s; then > > + reply_ha=f000000000$d > > + else > > + reply_ha= > > > > Would it be helpful to update bullet "9" in the preceding description? > > > > > + fi > > + test_arp $s f000000000$s $sip $tip $reply_ha > > #9 > > test_arp $s f000000000$s $sip $tip_unknown > > #10 > > > > if test $jd = 3; then > > # lsp[123]3 has an additional ip 192.169.0.[123]3. > > tip=`ip_to_hex 192 169 0 $id$jd` > > - test_arp $s f000000000$s $sip $tip f000000000$d > > #9 > > + test_arp $s f000000000$s $sip $tip $reply_ha > > #9 > > fi > > done > > done > > @@ -1413,13 +1418,14 @@ for s in 1 2 3; do > > sip=192.168.0.$s > > tip=192.168.0.$d > > tip_unknown=11.11.11.11 > > - test_arp $s f0:00:00:00:00:0$s $sip $tip f0:00:00:00:00:0$d > > #9 > > + if test $d != $s; then reply_ha=f0:00:00:00:00:0$d; else > > reply_ha=; fi > > > > Would it be helpful to update bullet "9." in the preceding description? > > > > + test_arp $s f0:00:00:00:00:0$s $sip $tip $reply_ha > > #9 > > test_arp $s f0:00:00:00:00:0$s $sip $tip_unknown > > #10 > > > > if test $d = 3; then > > # lp3 has an additional ip 192.169.0.[123]3. > > tip=192.169.0.$d > > - test_arp $s f0:00:00:00:00:0$s $sip $tip f0:00:00:00:00:0$d > > #9 > > + test_arp $s f0:00:00:00:00:0$s $sip $tip $reply_ha > > #9 > > fi > > done > > > > -- > > 2.1.3 > > > > > Acked by: Darrell Ball <dlu...@gmail.com> Thanks for the review and the suggestions. I'll update the comments. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
