2016-09-29 3:27 GMT-07:00 Mark Kavanagh <[email protected]>:
> Coding style violations of the following conventions are present in
> netdev-dpdk.c:
> - limit lines to 79 characters
> - put a space after (but not before) the "sizeof" keyword.
> - put a space between the () used in a cast and the
> expression whose type is cast: (void *) 0.
>
> Resolve occurrences of each, and any other minor style infractions.
>
> Signed-off-by: Mark Kavanagh <[email protected]>
> ---
> lib/netdev-dpdk.c | 81 ++++++++++++++++++++++++++++++
> -------------------------
> 1 file changed, 44 insertions(+), 37 deletions(-)
>
>
Thanks for taking the time to fix all these!
I believe that the space after "sizeof" should only be there when the
operand is not parenthesized. A quick grep in the tree shows that "sizeof
(" is not very popular, at least in userspace code. Perhaps we should fix
this in CodingStyle.md? Anyway, I removed the space before the parenthesis.
I fixed a couple of more whitespaces around and applied this and the
previous patch to master
Thanks!
Daniele
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
