Much better. Thanks for addressing the comments. Acked-by: Nithin Raju <[email protected]>
-----Original Message----- From: dev <[email protected]> on behalf of Shashank Ram <[email protected]> Date: Monday, September 19, 2016 at 3:24 PM To: "[email protected]" <[email protected]> Cc: Shashank Ram <[email protected]> Subject: [ovs-dev] [PATCH v2] datapath-windows: Add define for last module number >Adds a define for the last defined module number. > >Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c >Signed-off-by: Shashank Ram <[email protected]> >--- > datapath-windows/ovsext/Debug.c | 1 + > datapath-windows/ovsext/Debug.h | 5 ++--- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/datapath-windows/ovsext/Debug.c >b/datapath-windows/ovsext/Debug.c >index a96d38d..c3d14ae 100644 >--- a/datapath-windows/ovsext/Debug.c >+++ b/datapath-windows/ovsext/Debug.c >@@ -25,6 +25,7 @@ > > UINT32 ovsLogFlags = 0xffffffff; > UINT32 ovsLogLevel = OVS_DBG_DEFAULT; >+BUILD_ASSERT(OVS_DBG_LAST < 31); /* 'ovsLogLevel' is 32 bits. */ > > #define OVS_LOG_BUFFER_SIZE 384 > >diff --git a/datapath-windows/ovsext/Debug.h >b/datapath-windows/ovsext/Debug.h >index 2175130..cae6ac9 100644 >--- a/datapath-windows/ovsext/Debug.h >+++ b/datapath-windows/ovsext/Debug.h >@@ -43,9 +43,8 @@ > #define OVS_DBG_CONTRK BIT32(23) > #define OVS_DBG_GENEVE BIT32(24) > >-#define OVS_DBG_LAST 24 // Set this to the last defined module >number. >-#define OVS_DBG_RESERVED BIT32(31) >-//Please add above OVS_DBG_LAST. >+#define OVS_DBG_LAST 24 /* Set this to the last defined module >number. */ >+/* Please add above OVS_DBG_LAST. */ > > #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL > #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL >-- >2.9.3.windows.2 > >_______________________________________________ >dev mailing list >[email protected] >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pN >HQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=aBoHFSv-pDjXxHXQ343r2asnUI_rF7 >c56636ZLZPhGs&s=rocZ4Y35Yytzqr9xocQc_zJGzGH0E2RcwXYM9hmbueY&e= _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
