[ovs-dev] [PATCH] datapath: compat: tunnels: Log error during initialization.

[Pravin B Shelar]

At present OVS compat tunneling can fail due to conflict with
already loaded tunneling kernel module. In this case openvswitch
kernel module loading fails silently. Following patch give more
clues about what went wrong.

Signed-off-by: Pravin B Shelar <pshe...@ovn.org>
---
 datapath/linux/compat/geneve.c | 1 +
 datapath/linux/compat/ip_gre.c | 1 +
 datapath/linux/compat/lisp.c   | 1 +
 datapath/linux/compat/stt.c    | 1 +
 datapath/linux/compat/vxlan.c  | 1 +
 5 files changed, 5 insertions(+)

diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c
index d99380a..0c5b58a 100644
--- a/datapath/linux/compat/geneve.c
+++ b/datapath/linux/compat/geneve.c
@@ -1711,6 +1711,7 @@ out3:
 out2:
        unregister_pernet_subsys(&geneve_net_ops);
 out1:
+       pr_err("Error while initializing GENEVE %d\n", rc);
        return rc;
 }
 
diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c
index 05e5178..03c5435 100644
--- a/datapath/linux/compat/ip_gre.c
+++ b/datapath/linux/compat/ip_gre.c
@@ -700,6 +700,7 @@ tap_ops_failed:
 add_proto_failed:
        unregister_pernet_device(&ipgre_tap_net_ops);
 pnet_tap_faied:
+       pr_err("Error while initializing GRE %d\n", err);
        return err;
 }
 
diff --git a/datapath/linux/compat/lisp.c b/datapath/linux/compat/lisp.c
index feef486..3a4bebc 100644
--- a/datapath/linux/compat/lisp.c
+++ b/datapath/linux/compat/lisp.c
@@ -783,6 +783,7 @@ int rpl_lisp_init_module(void)
 out2:
        unregister_pernet_subsys(&lisp_net_ops);
 out1:
+       pr_err("Error while initializing LISP %d\n", rc);
        return rc;
 }
 
diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
index d3ab833..ca9f039 100644
--- a/datapath/linux/compat/stt.c
+++ b/datapath/linux/compat/stt.c
@@ -2101,6 +2101,7 @@ int stt_init_module(void)
 out2:
        unregister_pernet_subsys(&stt_net_ops);
 out1:
+       pr_err("Error while initializing STT %d\n", rc);
        return rc;
 }
 
diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c
index b22a906..47a5a68 100644
--- a/datapath/linux/compat/vxlan.c
+++ b/datapath/linux/compat/vxlan.c
@@ -2259,6 +2259,7 @@ out3:
 out2:
        unregister_pernet_subsys(&vxlan_net_ops);
 out1:
+       pr_err("Error while initializing VxLAN %d\n", rc);
        return rc;
 }
 
-- 
1.8.3.1

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev