> On Sep 13, 2016, at 12:58 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Mon, Sep 12, 2016 at 01:52:37PM -0700, Jarno Rajahalme wrote: >> Later patches will need to create xlate cache entries from different >> modules. This patch refactors the xlate cache code in preparation >> without any functional changes, so that the changes are clearly >> visible in the following patches. >> >> The definition of XC_ENTRY_FOR_EACH() iterator macro is changed so >> that it now does not take the xlate cache pointer to unify the usage >> accross all call sites. >> >> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> >> --- >> v3: Separated xlate cache to it's own module. > > At the top of ofproto-dpif-xlate-cache.h, usually I alphabetize my > struct forward definitions. >
Done. Never used emacs sort-lines before :-) > Optionally we could get rid of the name for the 'u' member of struct > xc_entry, which would make references into the union a little more > convenient. > Done. > Thanks for working on this! > Did you skip the patch 06/13, or did I just not get the email? Either way, I’ll wait for that before pushing the rest of the series. > Acked-by: Ben Pfaff <b...@ovn.org> Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
