On Thu, Sep 8, 2016 at 9:13 AM, Justin Pettit <jpet...@ovn.org> wrote: > >> On Sep 2, 2016, at 10:09 PM, Zongkai LI <zealo...@gmail.com> wrote: >> >> This patch updates symbols in logical-fields for ND, such as "nd", >> "nd.target", "nd.sll", "nd.tll", to describe more clear about "icmp6.type" >> predicate. >> It adds new symbols: >> - "nd_rs" stands for Router Solicitation message, >> - "nd_ra" stands for Router Advertisement message, >> - "nd_rd" stands for Redirect message, >> >> v1 -> v2 >> rebased. >> --- > > Add "signed-off-by:" and move version information.
Thanks, I just know all my patches have problem with "signed-off-by:" and version information. > >> + expr_symtab_add_predicate(symtab, "nd_rd", >> + "icmp6.type == 137 && icmp6.code == 0 && ip.ttl == 255"); > > Are you using redirects anywhere? They require a different message type, > which I don't think has been introduced. I'd just drop it if you're not > introducing full support. > Not in this patch, but I was planning it. You're right, I shouldn't get it in for now. > --Justin > > Thanks for your review. :) Zongkai, LI _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
