> On Sep 1, 2016, at 11:04 PM, Guru Shetty <g...@ovn.org> wrote:
> 
> +AT_SETUP([ovn-nbctl - LBs])
> +OVN_NBCTL_TEST_START
> +
> +dnl Add two LBs
> +AT_CHECK([ovn-nbctl lb-add lb0 30.0.0.10:80 <http://30.0.0.10/> 
> 192.168.10.10:80 <http://192.168.10.10/>,192.168.10.20:80 
> <http://192.168.10.20/>])
> +AT_CHECK([ovn-nbctl lb-add lb1 30.0.0.10:80 <http://30.0.0.10/> 
> 192.168.10.10:80 <http://192.168.10.10/>,192.168.10.20:80 
> <http://192.168.10.20/> udp])
> +AT_CHECK([ovn-nbctl lb-list | ${PERL} $srcdir/uuidfilt.pl 
> <http://uuidfilt.pl/>], [0], [dnl
> +UUID                                   LB         PROTO    VIP               
>    IPs
> +<0>   lb0        tcp      30.0.0.10:80 <http://30.0.0.10/>         
> 192.168.10.10:80 <http://192.168.10.10/>,192.168.10.20:80 
> <http://192.168.10.20/>
> +<1>   lb1        udp      30.0.0.10:80 <http://30.0.0.10/>         
> 192.168.10.10:80 <http://192.168.10.10/>,192.168.10.20:80 
> <http://192.168.10.20/>
> +])
> +
> +dnl Update the lb1
> +AT_CHECK([ovn-nbctl --may-exist lb-add lb1 30.0.0.10:8080 
> <http://30.0.0.10:8080/> 192.168.10.10:80 
> <http://192.168.10.10/>,192.168.10.20:80 <http://192.168.10.20/> tcp])
> 
> A single load balancer can have multiple vips. So it would be nice if 
> 'lb-add' does not replace an existing different vip, but rather add the new 
> vip. If the vip already exists, it should replace it with the newly provided 
> "ips".  The "protocol" applies to all the vips in a load-balancer.   
> (I have only looked at the documentation and unit tests to start with. )

Thanks for your review, I will submit v4 patch soon.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to