On 30/08/2016 18:06, "Daniele Di Proietto" <diproiet...@vmware.com> wrote:

>
>
>
>
>
>On 30/08/2016 15:32, "Ben Pfaff" <b...@ovn.org> wrote:
>
>>On Tue, Aug 30, 2016 at 11:41:15AM -0700, Daniele Di Proietto wrote:
>>> We only changed the MTU of new internal ports if it is bigger than the
>>> bridge minimum.  But when the minimum MTU of the bridge is updated we
>>> change the MTU of all internal ports no matter what.
>>> 
>>> The behavior is inconsistent, because now the internal ports MTU depends
>>> on the order in which the ports where added.
>>> 
>>> This commit fixes the problem by _always_ setting the MTU of new
>>> internal ports to the bridge minimum.  I'm not sure what was the logic
>>> behind only adjusting the mtu if it was too big.
>>> 
>>> A testcase is improved to detect the problem.
>>> 
>>> VMware-BZ: #1718776
>>> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com>
>>
>>Acked-by: Ben Pfaff <b...@ovn.org>
>
>Thanks for the prompt reviews, I applied the series to master and branch-2.6

Unfortunately this patch broke the system testsuite.  I proposed a fix here,
but it involves changing a long standing behavior of Open vSwitch.

http://openvswitch.org/pipermail/dev/2016-August/078931.html 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to