On Tue, Aug 30, 2016 at 11:28:45AM -0700, Jarno Rajahalme wrote: > > On Aug 30, 2016, at 8:40 AM, Ben Pfaff <b...@ovn.org> wrote: > > I'm surprised to see ofproto.c including ofproto-dpif-xlate.h. That > > seems like a layer violation. > > I think this was due to the plate cache only. The learn action entries in > late cache use the struct ofproto_flow_mod, which the ofproto.c can operate > on. Apart from bundle revert these could be handled from ofproto-dpif.c with > calls to ofproto.c functions from there. To make the revert work I’d need to > add a new ofproto-provider class member function and have it iterate through > the late cache and then call back to ofproto.c to revert learned flows. > > Also, making the late cache a module of it’s own would remove the inclusion > of ofproto-dpif-xlate.h. Would this alleviate your concern with layer > violation, or should I strive to keep the xlate cache opaque to ofproto.c?
It would help a lot, if it's practical. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
