There's no similar special case for sets, but looking closer there
really were some additional leaks.

I sent a v2:
        https://patchwork.ozlabs.org/patch/663249/

On Fri, Aug 26, 2016 at 01:38:56PM -0700, Amitabha Biswas wrote:
> Hi Ben,
> 
> This seems to take care of datums of type is_map, do we need to need to the 
> same for type is_set()?
> 
> Thanks
> Amitabha
> 
> > On Aug 26, 2016, at 9:03 AM, Ben Pfaff <b...@ovn.org> wrote:
> > 
> > Found by inspection.
> > 
> > Signed-off-by: Ben Pfaff <b...@ovn.org>
> > ---
> > ovsdb/ovsdb-idlc.in | 4 ++++
> > 1 file changed, 4 insertions(+)
> > 
> > diff --git a/ovsdb/ovsdb-idlc.in b/ovsdb/ovsdb-idlc.in
> > index 487876b..40be763 100755
> > --- a/ovsdb/ovsdb-idlc.in
> > +++ b/ovsdb/ovsdb-idlc.in
> > @@ -957,6 +957,8 @@ void
> >                                    function,
> >                                    &%(s)s_columns[%(S)s_COL_%(C)s],
> >                                    &datum);
> > +
> > +    ovsdb_datum_destroy(&datum, &%(s)s_col_%(c)s.type);
> > }
> > """ % {'t': tableName,
> >        'T': tableName.upper(),
> > @@ -1123,6 +1125,8 @@ void
> >                                       function,
> >                                       &%(s)s_columns[%(S)s_COL_%(C)s],
> >                                       &datum);
> > +
> > +    ovsdb_datum_destroy(&datum, &%(s)s_col_%(c)s.type);
> > }
> > """ % {'t': tableName,
> >        'T': tableName.upper(),
> > -- 
> > 2.1.3
> > 
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to