On Fri, Aug 12, 2016 at 07:39:32AM +0000, Alin Serdean wrote: > This patch allows online compacting to be done under Windows. > > To achieve the above we need to close all file handles before trying to > rename the file, switch from rename to MoveFileEx (because rename/MoveFile > fails if the destination exists), reopen the right type of log after the > rename. > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>
I think that this introduces a new kind of failure. On other OSes, ovsdb_file_compact() always leaves 'file' open and usable regardless of whether it succeeds or fails. I think that on Windows it can fail and close 'file'. The callers don't expect that, so there needs to be some way to it to report the problem. And then we have to figure out how the database server should deal with it if its database got closed and cannot be reopened. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
