On 11 August 2016 at 17:58, Daniele Di Proietto <diproiet...@ovn.org> wrote:
>
>
> 2016-08-11 17:54 GMT-07:00 Joe Stringer <j...@ovn.org>:
>>
>> a716ef9a7a73 ("ofproto-dpif-xlate: Log flow in XLATE_REPORT_ERROR.")
>> inadvertantly broke build on clang due to improper passing of the ds
>> cstring into the VLOG() function:
>>
>> error: format string is not a string literal
>> (potentially insecure) [-Werror,-Wformat-security]
>> XLATE_REPORT_ERROR(ctx, "over max translation depth %d",
>> MAX_DEPTH);
>>
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> note: expanded from macro
>> 'XLATE_REPORT_ERROR'
>> VLOG_ERR_RL(&error_report_rl, ds_cstr(&ds)); \
>>
>> Reported-by: Daniele Di Proietto <diproiet...@vmware.com>
>> Signed-off-by: Joe Stringer <j...@ovn.org>
>
>
> Thanks for fixing it. It works for me now
>
> Acked-by: Daniele Di Proietto <diproiet...@vmware.com>
Thanks for the report, it seems my standard push prechecks skip the
clang compile so this fell through.
Applied to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
