When using compat GSO there is no need to turn on skb
encapsulation bit since OVS does not use any tunnel GSO
functionality from the networking stack.
Signed-off-by: Pravin B Shelar <pshe...@ovn.org>
---
datapath/linux/compat/gso.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c
index 10412c0..89df07f 100644
--- a/datapath/linux/compat/gso.c
+++ b/datapath/linux/compat/gso.c
@@ -187,8 +187,6 @@ static struct sk_buff *tnl_skb_gso_segment(struct sk_buff
*skb,
* make copy of it to restore it back. */
memcpy(cb, skb->cb, sizeof(cb));
- skb->encapsulation = 0;
-
/* We are handling offloads by segmenting l3 packet, so
* no need to call OVS compat segmentation function. */
@@ -238,6 +236,9 @@ static int output_ip(struct sk_buff *skb)
int rpl_ip_local_out(struct net *net, struct sock *sk, struct sk_buff *skb)
{
+ /* This bit set can confuse some drivers on old kernel. */
+ skb->encapsulation = 0;
+
if (!OVS_GSO_CB(skb)->fix_segment)
return output_ip(skb);
@@ -281,6 +282,8 @@ static int output_ipv6(struct sk_buff *skb)
int rpl_ip6_local_out(struct net *net, struct sock *sk, struct sk_buff *skb)
{
+ /* This bit set can confuse some drivers on old kernel. */
+ skb->encapsulation = 0;
if (!OVS_GSO_CB(skb)->fix_segment)
return output_ipv6(skb);
--
1.8.3.1
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
