Thank Ryan for looking into this big patch. We will have more concrete examples
to appear, but
before that, I need to wire this into ovsdb first.
We could think of the engine as a nice method of doing 'joins' with events,
e.g., when there is a port turning
into active state on a host, the check on related logical switch is needed.
Since events come in different order,
it is usually complex to manage event sequence directly. The engine will help
much on this.
There is one 'combo' test case under ovn. It contains 97 test cases and have an
interactive mode,
with which we could input rules and data entries to experiment with it.
-- Yusheng
________________________________________
From: Ryan Moats <rmo...@us.ibm.com>
Sent: Saturday, August 6, 2016 9:06 PM
To: Yusheng Wang
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH V2] OVN: Initial patch of datalog engine
"dev" <dev-boun...@openvswitch.org> wrote on 07/29/2016 02:00:33 AM:
> From: Yusheng Wang <yshw...@vmware.com>
> To: "dev@openvswitch.org" <dev@openvswitch.org>
> Date: 07/29/2016 02:01 AM
> Subject: [ovs-dev] [PATCH V2] OVN: Initial patch of datalog engine
> Sent by: "dev" <dev-boun...@openvswitch.org>
>
> From bc291ad6a1ec7f1e05455d36be05c655c61b243d Mon Sep 17 00:00:00 2001
> From: Yusheng Wang <yshw...@vmware.com>
> Date: Fri, 29 Jul 2016 12:26:49 +0800
> Subject: [PATCH V2] OVN: Initial patch of datalog engine
>
> Main changes:
> * Man page and code in the same patch.
> * Use prefix dtlog_ consistently in code.
> * Enhanced serialize method.
> Thank Ryan and Flaviof for comments.
>
> Signed-off-by: Yusheng Wang <yshw...@vmware.com>
>
> ---
As a nit, the patch has a couple of whitespace issues:
.git/rebase-apply/patch:3223: space before tab in indent.
dtlog_tuple_t* dt_ivt = dtlog_set_get(&dest_ivt->tuples, st);
.git/rebase-apply/patch:3665: space before tab in indent.
align_del = true;
.git/rebase-apply/patch:4058: trailing whitespace.
DTLOG_T(dtlog_ary_t*, int32_t) param1_org =
.git/rebase-apply/patch:4190: trailing whitespace.
if (dtlog_map_has(&eng->rule_set.output_tables,
.git/rebase-apply/patch:4243: trailing whitespace.
I fully admit that I still don't understand the documentation
(in other words, I really am not sure how to build anything
on top of this...) but that is for wiser heads than mine.
This does apply cleanly but the unit test is empty, so I'm
not 100% sure if this is to be considered a real patch or
an RFC...
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
