On Mon, Aug 01, 2016 at 07:03:14PM +0530, Babu Shanmugam wrote: > > > On Thursday 28 July 2016 01:48 AM, Ben Pfaff wrote: > >On Wed, Jul 20, 2016 at 08:02:03PM +0530,bscha...@redhat.com wrote: > >>>ovn-northd processes the list of Port_Bindings and hashes the list of > >>>queues per chassis. When it finds a port with qos_parameters and without > >>>a queue_id, it allocates a free queue for the chassis that this port > >>>belongs. > >>>The queue_id information is stored in the options field of Port_binding > >>>table. > >>>Adds an action set_queue to the ingress table 0 of the logical flows > >>>which will be translated to openflow set_queue by ovn-controller > >>> > >>>ovn-controller opens the netdev corresponding to the tunnel interface's > >>>status:tunnel_egress_iface value and configures a HTB qdisc on it. Then for > >>>each SB port_binding that has queue_id set, it allocates a queue with the > >>>qos_parameters of that port. It also frees up unused queues. > >>> > >>>This patch replaces the older approach of policing > >>> > >>>Signed-off-by: Babu Shanmugam<bscha...@redhat.com> > >I suggest folding in the following changes. Notably, set_queue(0); was > >documented but didn't work because QDISC_MIN_QUEUE_ID was 1. > > > >This series has no tests. I think that at least the DSCP marking > >feature could be tested with the existing OVN testing infrastructure. > >Will you work on that? > Ben, > I am trying to write a test case with the following sequence to test the > dscp marking. > - Add two ports (lp1, lp2) through ovn-nbctl and assign addresses > - Setup the vswitch db with external_ids:iface-id for the logical ports > created above > - Set options:qos_dscp on one logical port (lp1) through ovn-nbctl > - ofproto/trace a simple ip packet originating from lp1, and check if the > final flow has the DSCP bit set or not > > ofproto/trace is tracing out correctly only when qos_dscp is not set. When > qos_dscp is set, the controller adds includes an additional action > "0x22->OXM_OF_IP_DSCP[]" in table 16. With this, ofproto/trace says it drops > the packet after it passes through table 0. > > Do you have any suggestion on how to overcome this?
Hmm, that's odd. What's the whole trace output look like? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
