> On Jul 29, 2016, at 12:11 PM, Ben Pfaff <b...@ovn.org> wrote:
>
> On Thu, Jul 28, 2016 at 11:26:17PM -0700, Justin Pettit wrote:
>> This commit only supports static MAC bindings. A future commit will add
>> support for dynamic IPv6/MAC bindings. It has a few other limitations
>> described in "ovn/TODO".
>>
>> Signed-off-by: Justin Pettit <jpet...@ovn.org>
>
> Missing space after ")." below:
>> + <code>icmp6.type == 128 && icmp6.code == 0</code>
>> + (ICMPv6 echo request).The port of the router that receives the
>
> Let's put ip.ttl in <code></code>:
>
>> + echo request does not matter. Also, the ip.ttl of the echo
>> + request packet is not checked, so it complies with RFC 1812,
>> + section 4.2.2.9. Flows for ICMPv4 echo requests use the
>> + following actions:
>> </p>
>
> The \"\" below should be just "":
Fixed the issues mentions above. Thanks.
>> +nd_na {
>> + eth.src = <var>E</var>;
>> + ip6.src = <var>A</var>;
>> + nd.target = <var>A</var>;
>> + nd.tll = <var>E</var>;
>> + outport = inport;
>> + inport = \"\"; /* Allow sending out inport. */
>> + output;
>> +};
>
> op_put_v6_networks() doesn't, strictly speaking, need the special case
> for a single IP address; it's perfectly fine to put a single IP address
> in {}.
Yeah, I know. I just thought it made the generated flows prettier. :-)
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
