On Thu, Jul 28, 2016 at 05:56:02PM -0700, Jarno Rajahalme wrote: > This is a prepatory step for adding group mod support for bundles in a > following patch. > > Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
I'd usually see remove_groups_rcu() implemented more like this, avoiding the somewhat-confusing copying of 'groups' into a temporary: /* Removes and deletes groups from a NULL-terminated array of group * pointers. */ static void remove_groups_rcu(struct ofgroup **groups) OVS_EXCLUDED(ofproto_mutex) { ovs_mutex_lock(&ofproto_mutex); for (struct ofgroup **g = groups; *g; g++) { remove_group_rcu__(*g); } ovs_mutex_unlock(&ofproto_mutex); free(groups); } Acked-by: Ben Pfaff <b...@ovn.org> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev