On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote:
> Make groups RCU protected and make group lookups lockless.
>
> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
I'd add a little motivation to the commit message. A common reason to
switch to RCU is performance, but I doubt that this is the motivation
here. Rather, I suspect that it has more to do with having groups and
flows share the same synchronization mechanism so that it's easier to
understand. Also, I guess that later in the series you're going to need
versioning so that groups can be included in bundles.
I wasn't sure what to make of this new comment in ofproto-provider.h:
@@ -515,20 +515,22 @@ struct ofgroup {
const enum ofp11_group_type type; /* One of OFPGT_*. */
const long long int created; /* Creation time. */
const long long int modified; /* Time of last modification. */
+ /* const ?? */
struct ovs_list buckets; /* Contains "struct ofputil_bucket"s. */
const uint32_t n_buckets;
const struct ofputil_group_props props;
};
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
