On Thu, Jun 23, 2016 at 12:31 PM, Ben Pfaff <b...@ovn.org> wrote:

> On Mon, Jun 06, 2016 at 01:51:16PM -0700, Andy Zhou wrote:
> > Add more ovsdb lock tests.
> >
> > Signed-off-by: Andy Zhou <az...@ovn.org>
>
> This test checks c1-output twice, I suspect that the second check should
> be for c2-output:
>
Good catch.  Fixed.

>
> > +#
> > +# Two sessions create two locks. Both sessions should able get their own
> > +# lock immediately.
> > +OVSDB_CHECK_LOCK_SETUP([lock], [positive])
> > +AT_CHECK([ovsdb-client --detach lock unix:socket lock0 >c1-output 2>&1],
> > +      [0], [], [])
> > +AT_CHECK([ovsdb-client --detach lock unix:socket lock1 >c2-output 2>&1],
> > +      [0], [], [])
> > +OVS_APP_EXIT_AND_WAIT(["`pwd`"/svr-unixctl])
> > +OVS_WAIT_UNTIL([test ! -e server-pid])
> > +AT_CHECK([cat c1-output], 0, [{"locked":true}
> > +], [])
> > +AT_CHECK([cat c1-output], 0, [{"locked":true}
> > +], [])
> > +AT_CLEANUP
>
> Acked-by: Ben Pfaff <b...@ovn.org>
>

Thanks Ryan and Ben for the review.  Pushed to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to