On Thu, Jul 21, 2016 at 10:18:51AM -0400, Aaron Conole wrote: > Markos Chandras <mchand...@suse.de> writes: > > > Hi Aaron, > > > > On 07/20/2016 10:21 PM, Aaron Conole wrote: > >> This commit builds upon some of the recent ovs-ctl changes to build a > >> more integrated systemd setup. A new service (ovs-vswitchd) is > >> added to track the ovs-vswitchd, and ovsdb-server service is reserved > >> for the ovsdb-server daemon. The systemd scripts still use ovs-ctl to > >> actually initialize the daemons. > >> > > > >> > >> diff --git a/rhel/usr_lib_systemd_system_ovs-vswitchd.service > >> b/rhel/usr_lib_systemd_system_ovs-vswitchd.service > >> new file mode 100644 > >> index 0000000..d3d020a > >> --- /dev/null > >> +++ b/rhel/usr_lib_systemd_system_ovs-vswitchd.service > >> @@ -0,0 +1,18 @@ > >> +[Unit] > >> +Description=Open vSwitch Forwarding Unit > >> +After=ovsdb-server.service > >> +Requires=ovsdb-server.service > > [...] > > > >> diff --git a/rhel/usr_lib_systemd_system_ovsdb-server.service > >> b/rhel/usr_lib_systemd_system_ovsdb-server.service > >> index e4c2a66..847948e 100644 > >> --- a/rhel/usr_lib_systemd_system_ovsdb-server.service > >> +++ b/rhel/usr_lib_systemd_system_ovsdb-server.service > >> @@ -1,15 +1,18 @@ > >> [Unit] > >> -Description=Open vSwitch Internal Unit > >> +Description=Open vSwitch Database Unit > >> After=syslog.target > >> +ReloadPropagatedFrom=openvswitch.service > >> +Before=ovs-vswitchd.service > > > > Is the "Before=" here really necessary? You already have > > "After=ovsdb-server.service" in the ovs-vswitchd.service. > > You're correct - the `After=` is superfluous in the ovs-vswitchd.service > file; it won't matter because the Requires= takes precedence, but if > there are other comments, I'll submit a v2 with this removed.
Requires only says "I need this", but it doesn't tell the order, so both services could be started simultaneously, for instance. If you consider each service independently, it makes sense for ovs-vswitchd to require ovsdb-server and also to specify that it should run after ovsdb. But it doesn't make much sense to have ovsdb-server saying it should run before a service that it doesn't get impacted. In another words, I agree that it can be removed. > > Overall the change looks good to me so fwiw Same here. -- fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
