On Thu, Jul 14, 2016 at 03:03:05AM -0700, Jarno Rajahalme wrote:
> With a small question below:
>
> Acked-by: Jarno Rajahalme <ja...@ovn.org>
Thanks!
...
> > +AT_CHECK([ovs-ofctl -O OpenFlow13 dump-flows br0 | ofctl_strip], [0], [dnl
> > +OFPST_FLOW reply (OF1.3):
> > + reset_counts actions=set_queue:456,output:123,pop_queue
>
> I forget why we see 'reset_counts' here?
It's dumb.
The OpenFlow specification implies that all flags supplies on flow_mod
should be preserved as part of the flow and returned on flow dumps.
reset_counts in particular doesn't make any sense there because it's not
a state, it's an action to take. An OpenFlow 1.0 flow_mod always
implies reset_counts, so when we add a flow with OpenFlow 1.0 and then
dump them with a protocol that supports reset_counts (OF1.2+), we'll
always get reset_counts back.
The comments on enum ofputil_flow_mod_flags talk about this a little:
/* These flags primarily affects flow_mod behavior. They are not
* particularly useful as part of flow state. We include them in flow
* state only because OpenFlow implies that they should be. */
OFPUTIL_FF_CHECK_OVERLAP = 1 << 3, /* All versions. */
OFPUTIL_FF_RESET_COUNTS = 1 << 4, /* OpenFlow 1.2+. */
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
