On Mon, Jul 04, 2016 at 06:02:31PM +0000, Alin Serdean wrote: > > > I'm still not sure that real locking is actually needed for Windows. > > > I believe that, on Windows, the functionality of a lock file only > > > requires holding the file open. For a program to detect whether the > > > lock file is locked, it can just try to delete it; on Windows, I > > > believe that deleting an open file fails. > > [Alin Gabriel Serdean: ] That is correct Ben. But think about somebody which > > is using python and coming from a Unix environment, he will try to > > read/write to the locked file. In my opinion we should try to mimic that > > behavior. > Another problem would be we can write over the pid file and if we try to do > something like > $a = type .\ovs-vswitchd.pid > taskkill.exe /PID $a /F > Would be bogus because someone could have changed it.
It's OK with me if we actually lock the lockfiles, it just seems less necessary on Windows. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
