> -----Mesaj original-----
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 1, 2016 7:27 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V5 16/17] tests: Skip vlog tests that try to move
> opened file
>
> m4_define([VLOG_REOPEN_PYN],
> [AT_SETUP([vlog - vlog/reopen - $1])
> + # This test won't work as-is on Windows because Windows doesn't allow
> + # files that are open to be renamed.
> + AT_SKIP_IF([test "$IS_WIN32" = "yes"])
[Alin Gabriel Serdean: ] On this part I agree with you. Although we could
improvise using vlog/close and try to reopen the file, but that is tested in
the vlog/close test
> AT_SKIP_IF([test $2 = no])
> on_exit 'kill `cat test-unixctl.py.pid`'
>
> @@ -314,6 +317,9 @@ AT_CLEANUP
>
> m4_define([VLOG_CLOSE_PYN],
> [AT_SETUP([vlog - vlog/close - $1])
> + # This test won't work as-is on Windows because Windows doesn't allow
> + # files that are open to be renamed.
> + AT_SKIP_IF([test "$IS_WIN32" = "yes"])
[Alin Gabriel Serdean: ] I think we should leave this one enabled and try to
make it work. It will guarantee vlog/close and vlog/reopen to work.
> AT_SKIP_IF([test $2 = no])
> on_exit 'kill `cat test-unixctl.py.pid`'
>
> --
> 2.7.2.windows.1
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
