Re: [ovs-dev] [PATCH v4 15/17] system-tests: Add ping through conntrack test.

[Daniele Di Proietto]

On 24/06/2016 15:41, "Joe Stringer" <j...@ovn.org> wrote:

>On 10 June 2016 at 15:47, Daniele Di Proietto <diproiet...@vmware.com> wrote:
>> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com>
>
>Thanks, I didn't realise this basic test would actually be really
>helpful if there's something fundamentally going wrong in a setup. One
>minor comment below.
>
>Acked-by: Joe Stringer <j...@ovn.org>
>
>> +AT_CHECK([ovs-ofctl --bundle add-flows br0 flows.txt])
>> +
>> +dnl Without this sleep, we get occasional failures due to the following 
>> error:
>> +dnl "connect: Cannot assign requested address"
>> +sleep 2;
>
>Commit c10840ff42da ("system-traffic: Wait for IPv6 connectivity.")
>replaced all of these in the testsuite, could you also update this to
>do the following?
>
>OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00::2])

Thanks for noticing this! I made the suggested change
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev