Hi Zong Kai, Li,
My comments below.
On Thursday 23 June 2016 02:34 PM, Zong Kai YL Li wrote:
Hi, Babu.
I get a few questions about this patch:
- 1, About SB DB. It says to support ACLs, so why do we need a
identical table exists in both NB DB and NB DB? I can figure that out,
please give some explanation.
When address sets are created in NB DB, it will be present in ACLs, but
in SB DB it will be present in Logical_Flows. And the address-set
replica in SB DB will be used by the controller to construct openflow
flows from the Logical_Flows.
- 2, About addresses format. Should the addresses in the same set
keep the same format/type, all are MAC or IPv4 or IPv6 address format,
not mix.
if it should be, please update ovn-nb.xml for that.
Yes. It imposes the same restrictions as a list that is used in the
expression language. It is also necessary that the address set is used
in a list with the same format type. You can check that by
echo 'ip4.src == {1.2.0.0/20, ::1}' | ./tests/ovstest test-ovn expr-to-flows
which will fail.
- 3, About utilities. Directly insert data into DB seems horrible, I
prefer ovn-nbctl can support this.
and by this, you can check addresses format to avoid inconsistent.
and BTW, how about add a CLI to support extend addresses for a
address-set.
I think thats a good suggestion.
Thanks and have a nice day! :)
Zong Kai, LI
I hope I answered your questions.
Thank you,
Babu
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
