In what way do you intend to use tc capabilities to implement meters?
On Sun, Jun 19, 2016 at 11:43:33AM +0300, Vladimir Shebordaev wrote: > Hello, guys, > > sorry for the silence, I'm quite busy with my job at the moment, but OVS is > a pretty large pile of code. > > Well, it was my original intent to use the tc capabilities in the kernel > datapath. I've got some experience with qdiscs earlier, so I would like to > also consider your thoughts along my code studies. > > Thanks in advance. > > Regards, > Vladimir > > -- > Regards, > Vladimir > > 2016-06-10 9:54 GMT+03:00 Deepanshu Saxena1/CHN/TCS < > deepanshu.saxe...@tcs.com>: > > > Hi, > > > > I am sorry for the late response. I am working on the implementation of B. > > 19. 13-Meter action (EXT-379) of OF 1.5.1 to openvswitch. > > > > The linux kernel meter implementation should likely use "Traffic Control" > > module of linux. To implement meters we can create a mapping between the > > meter structures and the tc structures. The tc can then apply the > > corresponding qdisc, class and filters using the corresponding values from > > the input meter command. > > > > You can take a look on [1], [2] mail threads. > > If you have any other idea on the implementation, let me know so we can > > co-ordinate. > > > > [1] http://openvswitch.org/pipermail/dev/2016-April/069007.html > > [2] http://openvswitch.org/pipermail/dev/2016-April/069240.html > > > > Thanks, > > Deepanshu Saxena > > Tata Consultancy Services > > Mailto: deepanshu.saxe...@tcs.com > > Website: http://www.tcs.com > > > > > > To: Ben Pfaff <b...@ovn.org> > > From: Vladimir Shebordaev > > Sent by: "dev" > > Date: 06/08/2016 09:29AM > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] ovs meters implementation > > > > 2016-06-08 6:29 GMT+03:00 Ben Pfaff <b...@ovn.org>: > > > > > On Wed, Jun 08, 2016 at 06:10:50AM +0300, Vladimir Shebordaev wrote: > > > > I would like to work on OF meter implementation. It is said to be > > > > missing from both userspace and kernel datapaths, though it is > > > > implemented in the protocol. It is also said that attempts were made > > > > to implement it and the patches have been declined for various > > > > reasons but they are still su > > > g > > > gested as a starting point. > > > > > > > > Well, as far as I could find it on the list, a few years ago there was > > > > a patch series that proposed an implementation in userspace but it was > > > > dropped almost without a comment. > > > > > > I agree that it would be nice to support meters. > > > > > > The last posted implmentation was in December 2015. I provided a review: > > > http://openvswitch.org/pipermail/dev/2015-December/063724.html > > > I believe that if the problems I cited were fixed, this would be > > > suitable for inclusion in OVS. > > > > > > > > OK, thank you, it is axactly the patch series I was talking about but I > > missed your comments. I should study those patches in detail before I can > > continue on. > > > > > Are there any design documents around? I would like to made consistent > > > > implemention both it kernel and userspace datapaths, so there is > > > > something to discuss, I guess. > > > > > > What kind of design information are you looking for? > > > > > > > Basically, I mean I would like to also implement the meters in kernel > > datapath, so it would be nice to have consistent implementations. Sure, if > > it is possible. > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > > > > > > =====-----=====-----===== > > Notice: The information contained in this e-mail > > message and/or attachments to it may contain > > confidential or privileged information. If you are > > not the intended recipient, any dissemination, use, > > review, distribution, printing or copying of the > > information contained in this e-mail message > > and/or attachments to it are strictly prohibited. If > > you have received this communication in error, > > please notify us by reply e-mail or telephone and > > immediately and permanently delete the message > > and any attachments. Thank you > > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
