"dev" <dev-boun...@openvswitch.org> wrote on 06/15/2016 12:32:57 PM:

> From: William Townsend <wtown...@redhat.com>
> To: dev@openvswitch.org
> Date: 06/15/2016 12:33 PM
> Subject: [ovs-dev] [PATCH] Travis: added python plugins flake8 and
hacking.
> Sent by: "dev" <dev-boun...@openvswitch.org>
>
> Travis builds will now automatically run flake8 and hacking checks
against
> Python code and generate warnings.
>
> Signed-off-by: Willim Townsend <wtown...@redhat.com>
>
> ---

I can't test this out, but on visual inspection:

>  .travis.yml              | 2 +-
>  .travis/linux-prepare.sh | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index ee2cf21..79b5ab1 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -18,7 +18,7 @@ addons:
>
>  before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh
>
> -before_script: export PATH=$PATH:$HOME/bin
> +before_script: export PATH=$PATH:$HOME/bin:$HOME/.local/bin

Nit: it's not 100% clear to me why the above is here

>
>  sudo: false
>
> diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh
> index 752be9f..f8fc952 100755
> --- a/.travis/linux-prepare.sh
> +++ b/.travis/linux-prepare.sh
> @@ -3,3 +3,5 @@
>  git clone git://git.kernel.org/pub/scm/devel/sparse/chrisl/sparse.git
>  cd sparse && make && make install && cd ..
>  pip install --disable-pip-version-check --user six
> +pip install --user flake8
> +pip install --user hacking
> --

Given the above nit, this looks simple enough, so:

Acked-by: Ryan Moats <rmo...@us.ibm.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to