On Tue, Jun 14, 2016 at 02:36:57PM -0700, Andy Zhou wrote: > On Mon, Jun 13, 2016 at 2:54 PM, Ben Pfaff <b...@ovn.org> wrote: > > > Reported-by: james hopper <jameshop...@email.com> > > Reported-at: > > http://openvswitch.org/pipermail/discuss/2016-June/021662.html > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > > > Acked-by: Andy Zhou <az...@ovn.org>
Thanks, I applied this to master, branch-2.5, and branch-2.4. > For input "a:", does it make sense for ovs-ofctl to output "a=" instead of > "a"? Since ":a" outputs "=a". At any rate, this is conor case > of a test program, so it is not that important. To distinguish "a" from "a:", we'd need to return something different in the 'value' output parameter. Probably, we'd need to return NULL for no value, instead of "". That would change the function interface, which currently never returns NULL for the value. I can see both advantages and disadvantages to that change. However, it would require an audit of the callers to make sure that they can all tolerate NULL as an output value. I'd rather not do that in a bug fix patch, so I left it as-is. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
