"dev" <dev-boun...@openvswitch.org> wrote on 06/08/2016 09:02:20 AM:

> From: Alin Serdean <aserd...@cloudbasesolutions.com>
> To: "dev@openvswitch.org" <dev@openvswitch.org>
> Date: 06/08/2016 09:03 AM
> Subject: [ovs-dev] [PATCH] at test vlog: Switch from stderr to log
> Sent by: "dev" <dev-boun...@openvswitch.org>
>
> Using the --detach parameter the child does not propagate the first
> message to the parent.
>
> Proposed change use the log file instead of the stderr.
>
> Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>
> ---
>  tests/vlog.at | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/vlog.at b/tests/vlog.at
> index b793611..b96f394 100644
> --- a/tests/vlog.at
> +++ b/tests/vlog.at
> @@ -278,8 +278,9 @@ on_exit 'kill `cat test-unixctl.pid`'
>  AT_CAPTURE_FILE([log])
>  AT_CAPTURE_FILE([log.old])
>  AT_CHECK([ovstest test-unixctl --log-file=`pwd`/log --pidfile --detach],
> -  [0], [], [stderr])
> -AT_CHECK([vlog_filt stderr], [0], [opened log file
> +  [0], [], [ignore])
> +AT_CHECK([vlog_filt log], [0], [opened log file
> +Entering run loop.
>  ])
>
>  AT_CHECK([APPCTL -t test-unixctl log message])
> @@ -355,8 +356,9 @@ on_exit 'kill `cat test-unixctl.pid`'
>
>  AT_CAPTURE_FILE([log])
>  AT_CHECK([ovstest test-unixctl --log-file=`pwd`/log --pidfile --detach],
> -  [0], [], [stderr])
> -AT_CHECK([vlog_filt stderr], [0], [opened log file
> +  [0], [], [ignore])
> +AT_CHECK([vlog_filt log], [0], [opened log file
> +Entering run loop.
>  ])
>
>  AT_CHECK([APPCTL -t test-unixctl vlog/list | sed -n '1,2p
> --

This looks reasonable - I've not done anything past the basic make check,
so...

Acked-by: Ryan Moats <rmo...@us.ibm.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to