Hi Ryan, Thanks for the review. I looked at the jsonrpc-server.c and I think it's OK without leaks.
Regards, William On Wed, Jun 8, 2016 at 7:32 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 06/05/2016 09:37:35 AM: > >> From: William Tu <u9012...@gmail.com> >> To: dev@openvswitch.org >> Date: 06/05/2016 09:37 AM >> Subject: [ovs-dev] [PATCH] ovn-controller: Fix memory leak reported >> by valgrind. >> Sent by: "dev" <dev-boun...@openvswitch.org> >> >> Calling ovsdb_idl_set_remote() might overwrite the 'idl->session'. The >> patch >> fixes them by freeing 'idl->session' before it is overwritten. >> >> Testcast ovn-controller - ovn-bridge-mappings reports two definitelylosts >> in: >> xmalloc (util.c:112) >> jsonrpc_session_open (jsonrpc.c:784) >> ovsdb_idl_create (ovsdb-idl.c:246) >> main (ovn-controller.c:384) >> and, >> xmalloc (util.c:112) >> jsonrpc_session_open (jsonrpc.c:784) >> ovsdb_idl_set_remote (ovsdb-idl.c:289) >> main (ovn-controller.c:409) >> >> Signed-off-by: William Tu <u9012...@gmail.com> > > Looked at this by inspection and it makes sense. I also checked > ovsdb/jsonrpc-server.c but I don't think that usage leaks - William, did you > also check that? > > Acked-by: Ryan Moats <rmo...@us.ibm.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
