On Thu, Jun 09, 2016 at 12:12:39AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpet...@ovn.org>
I think the documentation can be improved. Suggested incremental
appended.
It's not actually necessary to call
nbrec_logical_router_verify_static_routes() when deleting all routes,
because the result of deleting all of them does not depend on what was
there before. (This comment is petty.)
Most of our *-add and *-del commands fail, by default, if there is
already a duplicate or if there is nothing matching to delete,
respectively, unless given --may-exist or --if-exists, respectively, but
these new commands do not behave that way. (In particular adding a
duplicate static route seems like annoying behavior.)
It would be nice for lr-route-list to warn about an invalid route
prefix. Just ignoring them is likely to confuse users.
Acked-by: Ben Pfaff <b...@ovn.org>
diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml
index ba6a1ed..e6c1de3 100644
--- a/ovn/utilities/ovn-nbctl.8.xml
+++ b/ovn/utilities/ovn-nbctl.8.xml
@@ -331,16 +331,19 @@
</dd>
</dl>
- <h1>Logical Route Commands</h1>
+ <h1>Logical Router Static Route Commands</h1>
<dl>
<dt><code>lr-route-add</code> <var>router</var> <var>prefix</var>
<var>nexthop</var> [<var>port</var>]</dt>
<dd>
Adds the specified route to <var>router</var>. <var>prefix</var>
- describes the IP prefix for this route. <var>nexthop</var>
- specifies the gateway to use for this route. If <var>port</var>
- is specified, packets that match this route will be sent out
- that port.
+ describes a IPv4 or IPv6 prefix for this route, such as
+ <code>192.168.100.0/24</code>. <var>nexthop</var> specifies the
+ gateway to use for this route, which should be the IP address of one of
+ <var>router</var> logical router ports or the IP address of a logical
+ port. If <var>port</var> is specified, packets that match this route
+ will be sent out that port. When <var>port</var> is omitted, OVN
+ infers the output port based on <var>nexthop</var>.
</dd>
<dt><code>lr-route-del</code> <var>router</var> [<var>prefix</var>]</dt>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
