On Fri, May 27, 2016 at 10:32:56AM +0800, Zong Kai LI wrote:
> From: lzklibj <[email protected]>
>
> This patch tries to implement ND for Logical_Port in OVN.
>
> Signed-off-by: lzklibj <[email protected]>
Thanks for working on this.
I'm CCing Justin, who is working on related features, to bring this
patch to his attention.
"sparse" says:
../ovn/controller/pinctrl.c:748:25: warning: cast to restricted ovs_be16
about this line:
na->rco_flags.hi = (ovs_be16)0x60;
Probably, you should use put_16aligned_be32().
In pinctrl.c, please #include <netinet/icmp6.h> after pinctrl.h.
Keeping pinctrl.h first ensures that it is self-contained.
The functions compose_na() and reload_metadata() in pinctrl.c should be
declared static, unless you want to make them public (and in that case
the prototypes should be in a header file instead).
I am concerned about alignment issues. I am not sure that the use of
ALIGNED_CAST here is safe on RISC platforms, because IPv6 addresses
aren't always aligned on a 32-bit boundary when they are inside Ethernet
packets with different encapsulations. It would probably be better to
use a different strategy to assure alignment, rather than to just assume
it.
Please add documentation for the new action, in ovn-sb.xml.
I see that there are a few notes and to-do items; I guess that's what
makes it a work-in-progress.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
